adjust 'New feedbacks are not shown in reason popup when there are too many feedbacks' #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o many feedbacks'
MrOrz
reviewed
Jan 7, 2024
There was a problem hiding this comment.
Thanks for looking into the issue!
Back in the hackathon I thought hiding feedbacks without comments may help us focusing on those with comments. However, it comes to my mind that showing feedbacks without comment can help the audience in:
- determine where the votes are from -- from other fact checkers, or from LINE users
- better spot coordinated inauthentic behavior, when a group of fake accounts upvote each other and downvote other legitimate replies.
Therefore, I think we should not filter out all those feedbacks that have no comments.
Instead, we can:
- Show those with comments first
- Then show comments without comments
- If there are more than 10 comments, put a "show all" link at the bottom of the list. Clicking them can show all the rest of the comments.
@marcussfu would you mind making the change?
|
ok, I'll change it. |
…o many feedbacks' new feedback
|
Alread modified, check please. |
MrOrz
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust limit to 1000, and hide feedbacks that no comment.